Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The issue in the circular test #244

Open
Yong2Sheng opened this issue Sep 28, 2024 · 2 comments
Open

The issue in the circular test #244

Yong2Sheng opened this issue Sep 28, 2024 · 2 comments

Comments

@Yong2Sheng
Copy link
Contributor

This is a reminder about the current issue with the spectral fitting.

  1. The fitting to the simulated Crab can't recover the input spectrum for simulation (see the tutorial notebook of the Crab spectral fitting).
  2. The circular test, fitting the injected Crab, also can't completely recover the spectrum used in source injection (see the graph below).
image So, our current summary is that the response we used in DC2 is not smooth enough. The data binned in `Em`, `Phi` and `PsiChi` suffers from low statistics.

Maybe this can be verified when we have a more populated response.

@Yong2Sheng
Copy link
Contributor Author

We also added a very small number 1e-12 to the likelihood to avoid expectation_bin == 0 while data_bin != 0, which might distort the total likelihood.

@eneights
Copy link
Contributor

When this is solved, we will need to update the spectral fit unit test, which fits data generated by the source injector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants