Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap v4 end of life #887

Open
SpeedyD opened this issue Mar 26, 2024 · 6 comments
Open

Bootstrap v4 end of life #887

SpeedyD opened this issue Mar 26, 2024 · 6 comments
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Milestone

Comments

@SpeedyD
Copy link
Contributor

SpeedyD commented Mar 26, 2024

Currently, Lorekeeper as we know it is still running on.. 4.1.3. (According to app.css that is.)

Bootstrap v4 has recently reached end of life.

It seems we have fairly little choice but to migrate to 5.3.x. As there are a whopping 53 breaking matters, JQuery being dropped and support for older browsers ended, this is not a great solution.

I did find a Migration tool )https://github.com/coliff/bootstrap-5-migrate-tool) - but I have no idea how useful this is in the long run.

ADDITION:
https://palcarazm.github.io/bootstrap5-toggle/
For our Bootstrap 4 specific toggles, this is 1:1 but for Bootstrap 5

@itinerare
Copy link
Collaborator

itinerare commented Mar 26, 2024

Yeah it's on the vague to-do list/will happen at some point. It's not that bad a migration just to do manually, really, though it does take a little bit.

@itinerare itinerare added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 26, 2024
@SpeedyD
Copy link
Contributor Author

SpeedyD commented Mar 26, 2024

In combination with the laravelcollective/html deprecation, I can imagine some annoyances, though...

@itinerare
Copy link
Collaborator

I mean, they're not likely to happen simultaneously anyway, so... not that big a concern.

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Mar 28, 2024

Added link to https://palcarazm.github.io/bootstrap5-toggle/ in my original message, as reminder that we need to swap out the toggle when we get to this.

@itinerare itinerare added this to the v4.0.0 milestone Mar 28, 2024
@liwoyadan
Copy link

Oh, I've actually done the update to v5 for an LK site in the past and it wasn't too bad...I'll go ahead and put this on my eventual to-do, and see about PRing it into develop sometime soon. I can probably knock in the FontAwesome v6 upgrade as well while I'm at it.

@itinerare
Copy link
Collaborator

Oh, that'd be wonderful! I'll need to split off a branch for v4 development (since it's a breaking change, functionally), but I can do that whenever you get a PR set up/handle the logistics there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

3 participants