Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search by subtype in Admin traits.. non-functional? #346

Open
SpeedyD opened this issue Jul 19, 2022 · 0 comments · Fixed by #735
Open

Search by subtype in Admin traits.. non-functional? #346

SpeedyD opened this issue Jul 19, 2022 · 0 comments · Fixed by #735
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@SpeedyD
Copy link
Contributor

SpeedyD commented Jul 19, 2022

Bug as reported:

(Main branch, last commit parent: f62ed9cf)

URL of page: <site>/admin/data/traits
Description of bug: Attempting to search by subtype of a trait.. returns all results.
How was the bug caused (exact steps to reproduce): Go to the Traits section in the Admin panel. Click 'Any Subtype' and pick a subtype from the dropdown box. Hit search.

Further details

Hilariously, I was looking at #233 because I was requesting search by subtype in the Encyclopedia/World section... and.. I then realized it's not working on the admin page. Kinda funny, but this is a function I'd like to see functioning.

@itinerare itinerare added bug Something isn't working good first issue Good for newcomers labels Jul 19, 2022
ScuffedNewt added a commit to ScuffedNewt/lorekeeper that referenced this issue Dec 6, 2023
@itinerare itinerare linked a pull request Dec 7, 2023 that will close this issue
itinerare pushed a commit that referenced this issue Dec 10, 2023
* fix issue #728

* fix #96

* fix #113

* Update birthday selector on register

* fix #225

* fix #226

* fix #346

* fix #558

* fix #460

* fix #459

* fix #91

* Apply fixes from #91 to prompt submissions

* refactor: fix blade formatting

* remove character item retention due to return input wackiness

* refactor: fix PHP styling

* array_unique on slugs for gallery

* add missing set active on user sidebars

* add comment history and bugfix for likes

* refactor: fix blade formatting

* tweak function docs and sales comments checks

* refactor: fix blade formatting

* Capitalise 'carbon' in UserService

* refactor: fix PHP styling

---------

Co-authored-by: Ne-wt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants