Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: UI facelift SwitchLanguageModal & AppFeedbackModal #654

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

JeangelLF
Copy link
Contributor

@JeangelLF JeangelLF commented Sep 13, 2024

Ticket

https://github.com/corona-school/project-user/issues/1323
Partially: https://github.com/corona-school/project-user/issues/1305

What was done?

  • Updated the SwitchLanguageModal & AppFeedbackModal to use the new components
  • Fixed toast behavior when a modal is open (for the AppFeedbackModal) by adding a portal for the toaster to render it on the body

Preview

Bildschirmfoto 2024-09-13 um 13 33 09 Bildschirmfoto 2024-09-13 um 13 33 20

@Jonasdoubleyou Jonasdoubleyou temporarily deployed to user-app-feat-ui-faceli-5tnhyn September 13, 2024 11:35 Inactive
@JeangelLF JeangelLF merged commit 317e605 into main Sep 14, 2024
3 checks passed
@JeangelLF JeangelLF deleted the feat/ui-facelift-global-modals branch September 14, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants