Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix jobs all log fail if only one fails #78

Open
brianjmurrell opened this issue Nov 24, 2022 · 4 comments
Open

Matrix jobs all log fail if only one fails #78

brianjmurrell opened this issue Nov 24, 2022 · 4 comments

Comments

@brianjmurrell
Copy link

If I create a workflow with a job that uses convictional/trigger-workflow-and-wait as a step in a 2 axis matrix, if (even only) one of the matrix jobs fails, all of them show as failed in the workflow.

Additionally, both jobs in the workflow show the work of convictional/trigger-workflow-and-wait for both of the axes of the matrix.

See https://github.com/daos-stack/argobots/actions/runs/3541802004/jobs/5946573980 for an example of this. Only Test RPMs on EL 8 (release/2.2) actually failed. _Test RPMs on EL 8 (master) actually succeeded.

@brianjmurrell
Copy link
Author

Any ideas here? I like this action, but it's failure here is going to be a blocker to being able to use it unfortunately.

@brianjmurrell
Copy link
Author

I see the logs for the example run I mentioned in my original description have expired. Would it be helpful if I recreated them?

@lironmatityahu
Copy link

can you solve this issue?
this is making my workflows complicated

@orim-orca
Copy link

@brianjmurrell it feels a bit more random than that. It should also sometimes succeed even if one fail, as the job will get the last running job of the one its triggering, and most of the times it will just be the last one triggered in the matrix.

The only solution I can think for this is some sleep mechanism for the matrix items, making you run them all in a window bigger than your wait window (which is usually 10 seconds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants