Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeRequest and dry run #648

Open
florian-milky opened this issue Feb 12, 2021 · 1 comment
Open

makeRequest and dry run #648

florian-milky opened this issue Feb 12, 2021 · 1 comment

Comments

@florian-milky
Copy link

florian-milky commented Feb 12, 2021

Expected Behavior

makeRequest is executed when the migration has been validated and confirmed

Actual Behavior

makeRequest runs when the migration is validated

Possible Solution

Steps to Reproduce

  1. write a migration
  2. use makeRequest
  3. run the migration
  4. observe that makeRequest ran even though you still haven't chosen to apply the migration in the cli

Context

Environment

  • Node Version:
  • Package Manager Version:
  • Operating System:
  • Package Version:
@nteague22
Copy link

Yes, I even have looked at using the context and wiring up getClient, but having the migrations seed pass some form of flag even to allow for developer conditional execution would be helpful -- i.e. pass if it is committing the change or validating, so it is safe to run / does not have side effects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants