Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are default-policy.json & default.yaml in wrong place? Shouldn't they be in containers/image? #2170

Open
rahilarious opened this issue Dec 1, 2023 · 4 comments
Open

Are default-policy.json & default.yaml in wrong place? Shouldn't they be in containers/image? #2170

rahilarious opened this issue Dec 1, 2023 · 4 comments

Comments

@rahilarious
Copy link
Contributor

rahilarious commented Dec 1, 2023 •
edited
Loading

According to Fedora's source spec, various "common" files are pulled from containers/{common,image,storage,shortnames} which makes sense as they're all modules. But these 2 common files are pulled from skopeo which already depends on containers/common, so it doesn't make sense to have both in skopeo.

All major distros (Fedora, debian, archlinux, gentoo, alpine, opensuse) are placing these 2 files in containers-common package.
Thoughts on moving them to containers/image?
rahilarious pushed a commit to rahilarious/skopeo that referenced this issue Dec 1, 2023
Migrating default-policy.json and default.yaml to containers/common
492ab56 
All major distros (Fedora, debian, archlinux, gentoo, alpine,
opensuse) are placing these 2 files in containers-common package. Why
not fix it upstream?

1st step towards addressing containers#2170

Signed-off-by: Rahil Bhimjiani <[email protected]>
@rahilarious rahilarious mentioned this issue Dec 1, 2023
Open
rahilarious pushed a commit to rahilarious/common that referenced this issue Dec 1, 2023
Receiving policy.json and default.yaml from containers/skopeo
4ff458d 
All major distros (Fedora, debian, archlinux, gentoo, alpine,
opensuse) are placing these 2 files in containers-common package. Why
not fix it upstream?

2nd step towards addressing containers/skopeo#2170

Signed-off-by: Rahil Bhimjiani <[email protected]>
@rahilarious rahilarious mentioned this issue Dec 1, 2023
Closed
rahilarious pushed a commit to rahilarious/skopeo that referenced this issue Dec 1, 2023
Migrating default-policy.json and default.yaml to containers/common
441249f 
All major distros (Fedora, debian, archlinux, gentoo, alpine,
opensuse) are placing these 2 files in containers-common package. Why
not fix it upstream?

1st step towards addressing containers#2170

Signed-off-by: Rahil Bhimjiani <[email protected]>
@mtrmac
Copy link
Contributor

mtrmac commented Dec 4, 2023

I have no opinion on the location of these files, I’ll fully defer to our packaging experts (and this must be coordinated with them).

@lsm5 @jnovy PTAL.

@rahilarious rahilarious changed the title Are default-policy.json & default.yaml in wrong place? Shouldn't they be in containers/common? Are default-policy.json & default.yaml in wrong place? Shouldn't they be in containers/image? Jan 25, 2024
@lsm5
Copy link
Member

lsm5 commented Sep 13, 2024

The 2 files in question are now in c/image.

@lsm5 lsm5 closed this as completed Sep 13, 2024
@mtrmac
Copy link
Contributor

mtrmac commented Sep 13, 2024

@lsm5 the Skopeo repo still contains copies. Can we remove them?

@mtrmac mtrmac reopened this Sep 13, 2024
@lsm5
Copy link
Member

lsm5 commented Sep 16, 2024

@lsm5 the Skopeo repo still contains copies. Can we remove them?

The containers-common rpm fetches them from c/image . So it should be safe to remove unless other tests need it.

rahilarious pushed a commit to rahilarious/skopeo that referenced this issue Sep 16, 2024
@rahilarious
Migrating default-policy.json and default.yaml to containers/common
6b73165 
All major distros (Fedora, debian, archlinux, gentoo, alpine,
opensuse) are placing these 2 files in containers-common package. Why
not fix it upstream?

1st step towards addressing containers#2170

Signed-off-by: Rahil Bhimjiani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lsm5 @mtrmac @rahilarious