Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support c/storage to c/storage copy without transformations #2599

Open
cgwalters opened this issue Oct 14, 2024 · 1 comment
Open

support c/storage to c/storage copy without transformations #2599

cgwalters opened this issue Oct 14, 2024 · 1 comment
Labels
kind/feature A request for, or a PR adding, new functionality

Comments

@cgwalters
Copy link
Contributor

See #2590

To summarize, the goal here is something like skopeo copy containers-storage:[overlay@srcpath+srcrunroot:trusted=true]registry.redhat.io/ubi9/ubi:latest copy containers-storage:[overlay@destpath+destrunroot]registry.redhat.io/ubi9/ubi:latest (copying between two c/storage instances) in a "bit for bit" style manner; we wouldn't attempt to re-serialize the source image into a new manifest (with uncompressed data).

Implicitly in this we're currently trusting the source - we're not re-verifying the signature vs the source manifest etc. It's "just a copy".

@cgwalters cgwalters added the kind/feature A request for, or a PR adding, new functionality label Oct 14, 2024
ckyrouac added a commit to ckyrouac/bootc that referenced this issue Oct 15, 2024
We are unable to copy a signed image from c/storage -> c/storage while
preserving the signature. See
containers/image#2599

fixes containers#812

Signed-off-by: Chris Kyrouac <[email protected]>
ckyrouac added a commit to ckyrouac/bootc that referenced this issue Oct 15, 2024
We are unable to copy a signed image from c/storage -> c/storage while
preserving the signature. See
containers/image#2599

fixes containers#812

Signed-off-by: Chris Kyrouac <[email protected]>
@cgwalters
Copy link
Contributor Author

cc osbuild/images#990

mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 22, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Signed-off-by: Miguel Martín <[email protected]>
mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 22, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Signed-off-by: Miguel Martín <[email protected]>
mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 22, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Signed-off-by: Miguel Martín <[email protected]>
mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 25, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Co-authored-by: Michael Vogt <[email protected]>
mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 29, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Co-authored-by: Michael Vogt <[email protected]>
github-merge-queue bot pushed a commit to osbuild/images that referenced this issue Oct 30, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Co-authored-by: Michael Vogt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Development

No branches or pull requests

1 participant