This repository has been archived by the owner on Feb 20, 2024. It is now read-only.

Split CUSTOM_SCRIPT_PATH enabled and livenessProbe #605

Open

jungrae-prestolabs opened this issue May 16, 2022 · 0 comments

jungrae-prestolabs commented May 16, 2022

https://github.com/confluentinc/cp-helm-charts/blob/v5.5.0/charts/cp-kafka-connect/templates/deployment.yaml#L113

Currently, If there is no CUSTOM_SCRIPT_PATH, We could not handle livenessProbe. Is it intensional?

How about

Extract livenessProbe from if CUSTOM_SCRIPT_PATH condition block
(optional) Generate readinessProbe, symmetrically

The text was updated successfully, but these errors were encountered:

jungrae-prestolabs mentioned this issue

Extract livenessProbe from CUSTOM_SCRIPT_PATH block and Generate readinessProbe #606

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.