Python 3.8 builds failing

[jakirkham]

The Python 3.8 jobs are seeing failures like this job. Snippet below:

 In file included from src/source/libscalene.cpp:93:
  /home/conda/feedstock_root/build_artifacts/scalene_1713294069178/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/python3.8/Python.h:44:10: fatal error: crypt.h: No such file or directory
     44 | #include <crypt.h>
        |          ^~~~~~~~~
  compilation terminated.

Likely a result of upstream changes ( conda-forge/linux-sysroot-feedstock#52 )

Fixing probably involves updating the include search paths

That said, Python 3.8 will be EOL'd October 2024. So maybe it is easier to just drop it now

[emeryberger]

Thanks - I was wondering what was going wrong. I've removed it from the build.

[jakirkham]

Ok after some discussion with a couple colleagues and a closer look at the build system, think we may want to make some tweaks to how scalene builds. This is independent of whether Python 3.8 is supported as it is relevant for all builds. Have raised an upstream issue ( plasma-umass/scalene#812 ) to discuss how we might want to approach this