From 020a71d8c0a58e6659ca4565d9c4cea1e8ec188c Mon Sep 17 00:00:00 2001
From: Christopher Hertel <mail@christopher-hertel.de>
Date: Fri, 8 Mar 2024 13:23:02 +0100
Subject: [PATCH] use version as argument for getInstallCommand

---
 src/Entity/Package.php                   | 6 ++----
 templates/package/view_package.html.twig | 2 +-
 tests/Entity/PackageTest.php             | 3 +--
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/Entity/Package.php b/src/Entity/Package.php
index b2d4d074a..ffa06024b 100644
--- a/src/Entity/Package.php
+++ b/src/Entity/Package.php
@@ -687,16 +687,14 @@ public function getType(): string|null
         return $this->type;
     }
 
-    public function getInstallCommand(): string
+    public function getInstallCommand(Version $version = null): string
     {
         $command = 'create-project';
 
         if ('project' !== $this->getType()) {
             $command = 'require';
 
-            /** @var Version $version */
-            $version = $this->getVersions()->first();
-            if ($version && $version->hasDevTag()) {
+            if (null !== $version && $version->hasDevTag()) {
                 $command .= ' --dev';
             }
         }
diff --git a/templates/package/view_package.html.twig b/templates/package/view_package.html.twig
index ecb46b127..5a740392f 100644
--- a/templates/package/view_package.html.twig
+++ b/templates/package/view_package.html.twig
@@ -46,7 +46,7 @@
 
             <div class="row">
                 <div class="col-md-8">
-                    <p class="requireme"><i class="glyphicon glyphicon-save"></i> <input type="text" readonly="readonly" value="{{ package.installCommand }}" /></p>
+                    <p class="requireme"><i class="glyphicon glyphicon-save"></i> <input type="text" readonly="readonly" value="{{ package.installCommand(expandedVersion) }}" /></p>
 
                     {% if not package.isAutoUpdated() and is_granted('update', package) %}
                         {% if "github.com" in package.repository %}
diff --git a/tests/Entity/PackageTest.php b/tests/Entity/PackageTest.php
index 936231ef9..ee50453b5 100644
--- a/tests/Entity/PackageTest.php
+++ b/tests/Entity/PackageTest.php
@@ -41,9 +41,8 @@ public function testInstallCommand(string $type, string $tag, string $expected):
         $package = new Package();
         $package->setName('vendor/name');
         $package->setType($type);
-        $package->addVersion($version);
 
-        self::assertSame($expected, $package->getInstallCommand());
+        self::assertSame($expected, $package->getInstallCommand($version));
     }
 
     public static function providePackageScenarios(): array