Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views and Controls: Label should derive from View #442

Open
compnerd opened this issue Mar 31, 2021 · 0 comments · May be fixed by #450
Open

Views and Controls: Label should derive from View #442

compnerd opened this issue Mar 31, 2021 · 0 comments · May be fixed by #450
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@compnerd
Copy link
Owner

Label should be a View, not a Control. Event handling can be done through GestureRecognizers.
@compnerd compnerd added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Mar 31, 2021
@yostane yostane linked a pull request Apr 8, 2021 that will close this issue
Open
compnerd added a commit that referenced this issue Apr 14, 2021
@compnerd
Gestures: add GestureRecognizer and GestureRecognizerDelegate
e19b318 
This adds the two base types for the hierarchy to support implementing
gesture recognizers.  This is meant to provide the proper interaction
detection for Label components.  Currently, Label incorrectly derives
from Control, when it should derive from View.

This works towards a solution for #442.
@compnerd compnerd mentioned this issue Apr 14, 2021
Merged
compnerd added a commit that referenced this issue Apr 14, 2021
@compnerd
Gestures: add GestureRecognizer and GestureRecognizerDelegate
eda9a66 
This adds the two base types for the hierarchy to support implementing
gesture recognizers.  This is meant to provide the proper interaction
detection for Label components.  Currently, Label incorrectly derives
from Control, when it should derive from View.

This works towards a solution for #442.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Label inherits View and clean event handling code yostane/swift-win32
1 participant
@compnerd