Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback subject should contain date and time #5564

Closed
OpenGreenStreet opened this issue Feb 18, 2024 · 10 comments · Fixed by #5797 · May be fixed by #5577
Closed

Feedback subject should contain date and time #5564

OpenGreenStreet opened this issue Feb 18, 2024 · 10 comments · Fixed by #5797 · May be fixed by #5577

Comments

@OpenGreenStreet
Copy link

OpenGreenStreet commented Feb 18, 2024

What is the user problem or growth opportunity you want to see solved?

Feedback subject should contain date and time.

How do you know that this problem exists today? Why is this important?

If a user submits multiple feedback with the same version of the Commons app, these cannot be distinguished in the overview.

Who will benefit from it?

all users

Anything else you would like to add?

see here: https://commons.wikimedia.org/wiki/File:20240218_xl_171823-Commons_App-Feedback.jpg

https://commons.wikimedia.org/wiki/Commons:Mobile_app/Feedback

@Gupta-Suruchi
Copy link

Gupta-Suruchi commented Feb 21, 2024

Hii! I'm a newbie open source contributor & Can I please get assigned for this issue? I believe I can fix it:)

@nicolas-raoul
Copy link
Member

@protonpluss It is yours, thanks! :-)

If possible, please make the wiki generate the datetime by inserting just ~~~~~. That way, the user's timezone will not introduce a discrepancy with the datetime in the signature.

@Gupta-Suruchi
Copy link

If possible, please make the wiki generate the datetime by inserting just ~~~~~. That way, the user's timezone will not introduce a discrepancy with the datetime in the signature.

sure, I'll make it to generate default date and time by inserting ~~~~~.

Gupta-Suruchi added a commit to Gupta-Suruchi/apps-android-commons that referenced this issue Feb 29, 2024
Made Changes in app/src/main/java/fr/free/nrw/commons/feedback/FeedbackContentCreator.java

Added current Date & Time feature in feedback Content
@Gupta-Suruchi
Copy link

Hi @nicolas-raoul, Sorry for the delay. I have added the feature, can you Please take a look!

@OpenGreenStreet
Copy link
Author

someone aks me: "If a user submits multiple feedback with the same version of the Commons app, these cannot be distinguished in the overview. - Where can I see this. . . ."

you can see it here:
https://commons.wikimedia.org/wiki/File:20240218_xl_171823-Commons_App-Feedback.jpg

@ujjwal2900
Copy link
Contributor

Hi @nicolas-raoul, if this issue is still open and not yet resolved, can i take this up ?

@nicolas-raoul
Copy link
Member

@ujjwal2900 Any progress to share maybe? :-)

@ujjwal2900
Copy link
Contributor

Hi @nicolas-raoul I'll update by tomorrow.

@ujjwal2900
Copy link
Contributor

Hi @nicolas-raoul , I have created a PR - #5797 for this issue. Can u pls review it and suggest if there are any more changes required.
Thanks

@OpenGreenStreet
Copy link
Author

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment