Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Acura integra safety #1930

Closed

Conversation

vanillagorillaa
Copy link
Contributor

Opening as a starting point to start the discussion. The Integra does not have a ENGINE_DATA message, so the panda RX checks fail. For the moment I have removed this check for the port, but will want to come up with a clean way to do this.

Instead of using ENGINE_DATA (which uses the XMISSION_SPEED) signal for vEGO in openpilot, I've used the CAR_SPEED signal for vEGO instead.

@sshane Thoughts?

@adeebshihadeh adeebshihadeh added the car safety vehicle-specific safety code label Apr 15, 2024
@sshane
Copy link
Contributor

sshane commented Apr 23, 2024

Is this manual or automatic? Have a route? Will need a flag, but can we switch over the safety to use CAR_SPEED? If that always exists, are there any issues with it on existing cars? Edit: hmm, the minimum speed is ~double XMISSION_SPEED on our Accord

@vanillagorillaa
Copy link
Contributor Author

Neither the CVT or MT integra's have the ENGINE_DATA message (looked for it on different ID's but didn't find it at all). 0x309 will be used for CAR_SPEED

@jyoung8607
Copy link
Collaborator

If this gets picked up again, there's existing support in Panda to use one of three alternate messages to satisfy RxChecks. Usually we don't name any alternates, that's what the { 0 }, { 0 } at the end is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car safety vehicle-specific safety code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants