From 097dbd1e5177bd9f3e0c570d32dce6c8aed9875f Mon Sep 17 00:00:00 2001 From: Lorenzo Gabriele Date: Tue, 7 Nov 2023 11:38:27 +0100 Subject: [PATCH] Skip twirlCompile tests on java 8 --- .../twirllib/test/src/mill/twirllib/HelloWorldTests.scala | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/contrib/twirllib/test/src/mill/twirllib/HelloWorldTests.scala b/contrib/twirllib/test/src/mill/twirllib/HelloWorldTests.scala index 7534b7e7f02..bcd4be355a8 100644 --- a/contrib/twirllib/test/src/mill/twirllib/HelloWorldTests.scala +++ b/contrib/twirllib/test/src/mill/twirllib/HelloWorldTests.scala @@ -78,8 +78,9 @@ trait HelloWorldTests extends TestSuite { def skipUnsupportedVersions(test: => Unit) = { testTwirlVersion match { - case s"1.$minor.$_" - if minor.toIntOption.exists(_ > 5) && !scala.util.Properties.isJavaAtLeast(11) => + case s"1.$minor.$_" if minor.toIntOption.exists(_ < 6) => + test + case _ if !scala.util.Properties.isJavaAtLeast(11) => System.err.println(s"Skipping since twirl $testTwirlVersion doesn't support Java 8") case _ => test }