You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Check for existing records? and Check for existing terms? checkboxes on the Processing step do nothing. Both types of checks will happen, even if you uncheck the boxes. If you want to skip the checks, you can set them to false in the JSON batch config
I'm currently unable to figure out how to make checking/unchecking these update the attributes in the Step::Process instance.
Checking/unchecking these in the UI needs to trigger the batch.batch_config hash to be updated so the instructions sent to collectionspace-mapper are correct.
In addition, if a user pastes in a JSON batch.batch_config with check_terms or check_record_status keys, the checkboxes should be rendered appropriately in the UI. I had this part working in the commented out in the Step::Process model. OR, it was at least working to render the checkboxes appropriately checked/unchecked when you first land on the process step. But leaving that code uncommented causes Rails to fall over with an error message about there being no route for batches/batchID/step/processes/processID.
So I'm just leaving this for now. If you want to skip checking records/terms for now, you will just have to set up your batch with that in the JSON config, and the checkboxes don't actually do anything.
The text was updated successfully, but these errors were encountered:
I'm inclined to remove these options from the UI altogether because they control collectionspace-mapper behavior (which is the point of being able to send the mapper a JSON batch configuration). They complicate this app, and will be very rarely used, as they are only 100% safe with the very first batch you do on empty CollectionSpace instance.
As per [#6], I believe the best approach is to verify the status of each record before transferring it. I'm not sure I want to be able to turn that off at all.
The
Check for existing records?
andCheck for existing terms?
checkboxes on the Processing step do nothing. Both types of checks will happen, even if you uncheck the boxes. If you want to skip the checks, you can set them to false in the JSON batch configI'm currently unable to figure out how to make checking/unchecking these update the attributes in the
Step::Process
instance.Checking/unchecking these in the UI needs to trigger the
batch.batch_config
hash to be updated so the instructions sent tocollectionspace-mapper
are correct.In addition, if a user pastes in a JSON
batch.batch_config
withcheck_terms
orcheck_record_status
keys, the checkboxes should be rendered appropriately in the UI. I had this part working in the commented out in theStep::Process
model. OR, it was at least working to render the checkboxes appropriately checked/unchecked when you first land on the process step. But leaving that code uncommented causes Rails to fall over with an error message about there being no route forbatches/batchID/step/processes/processID
.So I'm just leaving this for now. If you want to skip checking records/terms for now, you will just have to set up your batch with that in the JSON config, and the checkboxes don't actually do anything.
The text was updated successfully, but these errors were encountered: