Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Coherence is broken with teh latest Twisted version (16.0.0) #25

Closed
wil93 opened this issue Mar 27, 2016 · 4 comments
Closed

Coherence is broken with teh latest Twisted version (16.0.0) #25

wil93 opened this issue Mar 27, 2016 · 4 comments

Comments

@wil93
Copy link

wil93 commented Mar 27, 2016

The latest stable (0.6.6.2) checks:

if twisted_web_version < Version("twisted.web", 2, 5, 0):

But with twisted/twisted@9bc27f6 the version field was changed for all submodules, and the .web part was dropped.

Maybe the check should be changed so that, when it throws an twisted.python.versions.IncomparableVersions exception, it checks:

if twisted_web_version < Version("twisted", 16, 0, 0):
@diederikh
Copy link

I have the same issue on OS X 10.11, Python 2.7.10

@hawkowl
Copy link

hawkowl commented Apr 17, 2016

(hi, I broke your code!)

It should not check against the twisted web version, only the Twisted version (twisted.__version__) in all cases, as that's part of Core, which was always available even pre-subproject removal, and Twisted and Twisted Web's version must have always been the same previously anyway.

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Apr 18, 2016
0-wiz-0 added a commit to 0-wiz-0/Coherence that referenced this issue May 9, 2016
Addresses coherence-project#25

Signed-off-by: Thomas Klausner <[email protected]>
@htgoebel
Copy link
Member

This project is seeking a maintainer, see #33. If you want this to be fixed, please provide a pull-request or volunteer to maintain the project.

@wil93
Copy link
Author

wil93 commented Jan 19, 2020

I think this was already fixed by PR #27

@wil93 wil93 closed this as completed Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants