Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3] Move selectedArticleId from context to action payload #369

Merged
merged 2 commits into from
Nov 22, 2023
Merged

[3] Move selectedArticleId from context to action payload #369

merged 2 commits into from
Nov 22, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 18, 2023 •
edited
Loading

Fixes #327

  • Removes selectedArticleId from context
    • We embed selectedArticleId to payload action instead
  • choosingReply defines the payload input type and loads selectedArticleId from postback payload

@MrOrz MrOrz changed the base branch from master to remove-selected-in-context October 18, 2023 04:32
Base automatically changed from remove-selected-in-context to master October 18, 2023 18:04
@MrOrz MrOrz changed the base branch from master to refactor-text-msg November 12, 2023 17:37
This was referenced Nov 12, 2023
Merged
Merged
@MrOrz Graphite App
Copy link
Member Author

MrOrz commented Nov 12, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@coveralls
Copy link

coveralls commented Nov 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6842218854

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 89.851%
Totals Coverage Status
Change from base Build 6841998040: 0.2%
Covered Lines: 969
Relevant Lines: 1043
💛 - Coveralls

@MrOrz MrOrz changed the title [4] Move selectedArticleId from context to action payload [3] Move selectedArticleId from context to action payload Nov 12, 2023
@MrOrz MrOrz requested review from yhsiang and nonumpa and removed request for yhsiang November 14, 2023 18:49
@MrOrz MrOrz marked this pull request as ready for review November 14, 2023 18:49
This was referenced Nov 19, 2023
Merged
Draft
@MrOrz Graphite App
Copy link
Member Author

MrOrz commented Nov 22, 2023 •
edited
Loading

Merge activity

  • Nov 22, 8:01 AM: @MrOrz started a stack merge that includes this pull request via Graphite.
  • Nov 22, 8:01 AM: @MrOrz merged this pull request with Graphite.

Base automatically changed from refactor-text-msg to master November 22, 2023 13:01
@MrOrz MrOrz merged commit 626b5af into master Nov 22, 2023
9 of 10 checks passed
@MrOrz MrOrz deleted the id-in-context branch November 22, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@nonumpa nonumpa Awaiting requested review from nonumpa

@yhsiang yhsiang Awaiting requested review from yhsiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot record feedback in certain state
3 participants
@MrOrz @coveralls @bil4444