add more logs in signup service

[mfrancisc]

Add some more logs to confirm that relying on the signup.Status.Ready field can create issues when the Space is being updated.

This will help out investigating the following bugs/issues :

• on the UI side , see https://issues.redhat.com/browse/SANDBOX-72
• when deleting SBR resources we sometimes notice this error message:

I0905 11:31:04.501991    3655 helpers.go:246] server response object: [{
  "metadata": {},
  "status": "Failure",
  "message": "an error on the server (\"unable to get target cluster: user is not provisioned (yet)\") has prevented the request from succeeding",
  "reason": "InternalError",
  "details": {
    "causes": [
      {
        "reason": "UnexpectedServerResponse",
        "message": "unable to get target cluster: user is not provisioned (yet)"
      }
    ]
  },
  "code": 500
}]
Error from server (InternalError): an error on the server ("unable to get target cluster: user is not provisioned (yet)") has prevented the request from succeeding

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[alexeykazakov]

Some flaky test?

    nstemplateset.go:17: verifying NSTemplateSet 'space-clusterole-tenant' and its resources
    host.go:976: waiting until NSTemplateTier 'appstudio' in namespace 'toolchain-host-05143622' matches criteria
    member.go:685: waiting for NSTemplateSet 'space-clusterole-tenant' to match criteria
    member.go:555: failed to find NSTemplateSet with matching criteria after 120.000000s:
        ----
        actual:
        metadata:
          creationTimestamp: "2023-09-05T15:05:18Z"
          deletionGracePeriodSeconds: 0
          deletionTimestamp: "2023-09-05T15:05:48Z"
          finalizers:
          - finalizer.toolchain.dev.openshift.com
          generation: 2
          name: space-clusterole-tenant
          namespace: toolchain-member2-05143622
          resourceVersion: "87049"
          uid: b7bac58f-43b7-41a4-b69c-9ee55a076938
        spec:
          clusterResources:
            templateRef: appstudio-clusterresources-e0e1f34-e0e1f34
          namespaces:
          - templateRef: appstudio-tenant-8e845ec-8e845ec
          tierName: appstudio
        status:
          conditions:
          - lastTransitionTime: "2023-09-05T15:05:48Z"
            reason: Terminating
            status: "False"
            type: Ready
          provisionedNamespaces:
          - name: space-clusterole-tenant-tenant
            type: default
        
        ----
        diffs:
        expected space roles to not be empty.
        
    nstemplateset.go:21: 
        	Error Trace:	/tmp/toolchain-e2e/testsupport/tiers/nstemplateset.go:21
        	            				/tmp/toolchain-e2e/testsupport/space/space.go:157
        	            				/tmp/toolchain-e2e/testsupport/space/space.go:116
        	            				/tmp/toolchain-e2e/test/e2e/space_autocompletion_test.go:200
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestAutomaticClusterAssignment/set_cluster-role_label_only_on_member2_cluster_and_expect_it_will_be_selected

[alexeykazakov]

/retest

[codecov]

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed	Coverage
pkg/proxy/service/cluster_service.go	100.00%
pkg/signup/service/signup_service.go	100.00%

📢 Thoughts on this report? Let us know!.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexeykazakov,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mfrancisc]

Some flaky test?

@alexeykazakov yeah, that's strange. Let's keep an eye on it. Thanks for retesting!