Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Look and Feel of TreemapExport #332

Open
jedpittman opened this issue Mar 9, 2021 · 8 comments
Open

Update Look and Feel of TreemapExport #332

jedpittman opened this issue Mar 9, 2021 · 8 comments
Assignees

Comments

@jedpittman
Copy link
Collaborator

jedpittman commented Mar 9, 2021

Make these two changes to the treemap export:

  1. JobHopper export is showing treechart as very difficult to read: Image is squished. Would be better if image was equally scaled so nothing is cutoff and the letters are similar to other items.
  2. Header on the export should match the header in the webpage.

For Review, please have Lewis/Ram/Jeff/Allan/Lillian review the changes. Reach out them in slack and leave a note in the comments. Once someone reviews, make a comment in the ticket that this looks good and is approved. Another team member will then merge.

A good review will:

  1. Ensure all bullets are done.
  2. Ensure the code runs on your machine locally and works as expected.
  3. Ensure that the tests run on your machine locally
  4. There are no unresolved conflicts/errors with tests for the merge request.
@jedpittman
Copy link
Collaborator Author

A second option is to have a page layout that is more print friendly rather than the canvas option that is currently present.

@edward-malouf
Copy link
Collaborator

@jkoren
Copy link
Collaborator

jkoren commented Apr 7, 2021

After some discussion, it seems like the tools used to create the PDF may not be able to handle printing the treemap with labels. Also, some discussion of how useful the printed version of the treemap would be as many titles are shortened to fit in tiles, and appear in full only in mouseovers.
Agreement to investigate other PDF creation approaches and also talk with sponsors to understand the use case and importance of the exported PDF.

Screen shot from on screen treemap:
image

Current PDF export:
image

@edward-malouf
Copy link
Collaborator

edward-malouf commented Apr 7, 2021 via email

@jkoren
Copy link
Collaborator

jkoren commented Apr 14, 2021

I did not find anything to create PDFs in React without adding complexity to the application.

@edward-malouf
Copy link
Collaborator

edward-malouf commented Apr 14, 2021 via email

@jedpittman
Copy link
Collaborator Author

The export functionality would still be nice, so for now I am keeping this open and reassigning it to myself for investigation.
However, it currently doesn't seem like something that is easy to implement reliably.

@jedpittman jedpittman assigned jedpittman and unassigned jkoren May 8, 2021
@edward-malouf
Copy link
Collaborator

edward-malouf commented May 8, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants