Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty result back #331

Open
alexjball opened this issue Mar 9, 2021 · 2 comments
Open

Add empty result back #331

alexjball opened this issue Mar 9, 2021 · 2 comments
Assignees

Comments

@alexjball
Copy link
Member

alexjball commented Mar 9, 2021

Make fixes as described:

  1. This was removed in a recent merge commit. We should add it back.
    } else if (hasResults && !hasTransitions) {
  2. Add a test where the code is run with a result but no transitions and ensure that the expected result is generated to guard against this behavior in the future.
@jedpittman
Copy link
Collaborator

@alexjball , I want to make sure that this works as expected and that there's a test to make sure this doesn't get removed by mistake again.

When do we think we'd have results but no transitions?

Can you provide more detail as to how we know this is causing a failure and how we might avoid making a regression in the future where this gets accidentally removed again? Once this is updated, we can look at assigning.

@alexjball
Copy link
Member Author

This was removed due to an error in merge commits--tests wouldn't really cover this. Once conflicts are resolved it's good to look over the code again to ensure omissions did not occur.

"Results" in this context means a response from the API for the user's choice of occ/state. We can get back no transitions if all the transitions are below the cutoff threshold.

Justification was given in the original issue #267

@jedpittman jedpittman self-assigned this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants