You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a test where the code is run with a result but no transitions and ensure that the expected result is generated to guard against this behavior in the future.
The text was updated successfully, but these errors were encountered:
@alexjball , I want to make sure that this works as expected and that there's a test to make sure this doesn't get removed by mistake again.
When do we think we'd have results but no transitions?
Can you provide more detail as to how we know this is causing a failure and how we might avoid making a regression in the future where this gets accidentally removed again? Once this is updated, we can look at assigning.
This was removed due to an error in merge commits--tests wouldn't really cover this. Once conflicts are resolved it's good to look over the code again to ensure omissions did not occur.
"Results" in this context means a response from the API for the user's choice of occ/state. We can get back no transitions if all the transitions are below the cutoff threshold.
Justification was given in the original issue #267
Make fixes as described:
jobhopper/frontend/src/ui/Results/Results.tsx
Line 201 in ab13d73
The text was updated successfully, but these errors were encountered: