Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up code style stuff throughout the app #1018

Open
16 of 17 tasks
knod opened this issue Nov 24, 2018 · 0 comments
Open
16 of 17 tasks

Clean up code style stuff throughout the app #1018

knod opened this issue Nov 24, 2018 · 0 comments
Assignees
@knod
Labels
infrastructure

Comments

@knod
Copy link
Collaborator

knod commented Nov 24, 2018 •
edited
Loading

We'll use our current understanding of the code style for now. Further discussions can be had if needed, but they'll be saved for future changes.

Maybe we can use this opportunity to make an explicit style guide.

Assume '/src' comes before all these directories. Some directories still need to be broken up into smaller chuncks.

  • /components
    • /dev for @knod
    • /prompts for @knod
    • through ExternalLink.js for @knod
    • through headings.js for @knod
    • through Surrounder.js for @knod
  • /containers
  • /data
  • /forms
    • /output
    • others
  • /localization?
  • /programs
  • /utils
  • App.js
  • index.js
  • index.css (!important, etc)
@knod knod self-assigned this Nov 24, 2018
knod added a commit that referenced this issue Nov 25, 2018
@knod
Merge pull request #1017 from knod/clean-style-1
5839c90 
Code style cleaning in '/src/components/dev',  #1018
knod added a commit to knod/cliff-effects-1 that referenced this issue Nov 25, 2018
@knod
Style cleans '/src/components' through 'ExternalLink.js'. codeforbost…
c5a889d 
…on#1018
knod added a commit to knod/cliff-effects-1 that referenced this issue Nov 25, 2018
@knod
Cleans code style of '/src/components' through 'headers.js`. codeforb…
ecf85ef 
…oston#1018
knod added a commit to knod/cliff-effects-1 that referenced this issue Nov 25, 2018
@knod
Cleans code style of '/src/components' through 'Surrounder`. codeforb…
ae5e48b 
…oston#1018
knod added a commit to knod/cliff-effects-1 that referenced this issue Nov 25, 2018
@knod
Cleans code style of '/src/containers'. codeforboston#1018
436efad
knod added a commit to knod/cliff-effects-1 that referenced this issue Nov 25, 2018
@knod
Cleans code style of '/src/data'. codeforboston#1018
cb6de6d
knod added a commit that referenced this issue Nov 28, 2018
@knod
Merge pull request #1025 from knod/clean-style-5
15a2a67 
Cleans code style of '/src/components' through 'Surrounder`. #1018
knod added a commit that referenced this issue Nov 29, 2018
@knod
Merge pull request #1027 from knod/code-style-7
fcc54f9 
Cleans code style of '/src/data'. #1018
knod added a commit that referenced this issue Nov 29, 2018
@knod
Merge pull request #1028 from knod/code-style-8
befb0ae 
Cleans code style of '/src/forms/output'. #1018
knod added a commit to knod/cliff-effects-1 that referenced this issue Nov 29, 2018
@knod
Cleans through 'src/forms/CurrentExpenses.js'. #codeforboston#1018
d167972
knod added a commit to knod/cliff-effects-1 that referenced this issue Dec 1, 2018
@knod
Cleans '/src/forms' through 'Household.js'. codeforboston#1018
a84811e
knod added a commit to knod/cliff-effects-1 that referenced this issue Dec 1, 2018
@knod
Cleans rest of '/src/forms'. codeforboston#1018
3334471
knod added a commit to knod/cliff-effects-1 that referenced this issue Dec 1, 2018
@knod
Cleans '/src/localization'. codeforboston#1018
1f86654 
@todo Get rid of quotes around keys in google docs then copy paste
into local files
knod added a commit that referenced this issue Dec 2, 2018
@knod
Merge pull request #1023 from knod/clean-style-3
3553ff3 
Style cleans '/src/components' through 'ExternalLink.js'. #1018
knod added a commit that referenced this issue Dec 2, 2018
@knod
Merge pull request #1024 from knod/clean-style-4
6c70739 
Cleans code style of '/src/components' through 'headers.js`. #1018
knod added a commit that referenced this issue Dec 2, 2018
@knod
Merge pull request #1021 from knod/clean-style-2
8b2ce5d 
Clean up code style, part 2 of many parts. The prompts folder. #1018
knod added a commit that referenced this issue Dec 2, 2018
@knod
Merge pull request #1032 from knod/code-style-10
68e9402 
Cleans '/src/forms' through 'Household.js'. #1018
knod added a commit that referenced this issue Dec 2, 2018
@knod
Merge pull request #1026 from knod/clean-style-6
8083aca 
Cleans code style of '/src/containers'. #1018
knod added a commit that referenced this issue Dec 2, 2018
@knod
Merge pull request #1031 from knod/code-style-9
91a1908 
Cleans through 'src/forms/CurrentExpenses.js'. #1018
knod added a commit to knod/cliff-effects-1 that referenced this issue Dec 2, 2018
@knod
Cleans '/src/programs'. codeforboston#1018
c697f07
knod added a commit to knod/cliff-effects-1 that referenced this issue Dec 2, 2018
@knod
Cleans /src/utils/charts. codeforboston#1018
4d47463
knod added a commit to knod/cliff-effects-1 that referenced this issue Dec 2, 2018
@knod
Cleans '/src/utils' through 'interpolation.js'. codeforboston#1018
5bc13f7
knod added a commit to knod/cliff-effects-1 that referenced this issue Dec 2, 2018
@knod
Cleans '/src/utils' through 'interpolation.js'. codeforboston#1018
24ef6b9
knod added a commit to knod/cliff-effects-1 that referenced this issue Dec 2, 2018
@knod
Cleans /src/utils/charts. codeforboston#1018
78bd932
knod added a commit to knod/cliff-effects-1 that referenced this issue Dec 2, 2018
@knod
Finishes cleaning '/src/utils'. codeforboston#1018. Also codeforbosto…
d2ae9d3 
…n#708.

Maybe fixes both of those. We shall see.
knod added a commit to knod/cliff-effects-1 that referenced this issue Dec 3, 2018
@knod
Cleans /src/App.js and /src/index.js. codeforboston#1018
75e446d
knod added a commit that referenced this issue Dec 5, 2018
@knod
Merge pull request #1035 from knod/code-style-11
9c3a15d 
Finisheds '/src/forms' and, apparently, '/src/localization'. #1018
knod added a commit that referenced this issue Dec 5, 2018
@knod
Merge pull request #1036 from knod/code-style-12
70bd223 
Cleans '/src/programs'. #1018
knod added a commit that referenced this issue Dec 5, 2018
@knod
Merge pull request #1040 from knod/code-style-16
0d478f9 
Cleans /src/App.js and /src/index.js. #1018
knod added a commit that referenced this issue Dec 6, 2018
@knod
Merge pull request #1038 from knod/code-style-13
e8f3666 
Cleans /src/utils/charts. #1018
knod added a commit that referenced this issue Dec 6, 2018
@knod
Merge pull request #1039 from knod/code-style-15
6e5e8c0 
Finishes cleaning '/src/utils'. #1018. Also #708.
knod added a commit that referenced this issue Dec 12, 2018
@knod
Merge pull request #1037 from knod/code-style-14
e4d5566 
Cleans '/src/utils' through 'interpolation.js'. #1018. Also #708.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knod knod

Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knod