Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposed coveralls token #2

Open
dsernst opened this issue Oct 12, 2015 · 0 comments
Open

Exposed coveralls token #2

dsernst opened this issue Oct 12, 2015 · 0 comments

Comments

@dsernst
Copy link

dsernst commented Oct 12, 2015

https://github.com/codedoctor/hapi-loggly/blob/master/Gruntfile.coffee#L41 exposes your coveralls token, which is meant to be kept secret. Not the biggest issue in the world — worst case is a bad actor makes your coverage say 0% — but still not ideal.

Better approach is use an environment variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsernst