Update PackageVersionFileController.ts #716
Conversation
WalkthroughThe pull request introduces two new HTTP method handlers, Changes
Assessment against linked issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/port/controller/PackageVersionFileController.ts (1)
174-189: LGTM! Consider these improvements for better maintainability.The
rawNpmVermethod successfully implements support for npm-style paths, aligning with the PR objectives. The logic for extracting version information and handling scoped packages is correct. Here are some suggestions to further improve the code:
- Add input validation for the
fullnameparameter to ensure it's properly formatted.- Include explanatory comments for the version extraction logic to improve readability.
- Consider renaming the method to something more descriptive, like
handleNpmStylePath, to better reflect its purpose.Here's a suggested refactor incorporating these improvements:
@HTTPMethod({ path: `/npm/:fullname(${FULLNAME_REG_STRING})/:path(.+)`, method: HTTPMethodEnum.GET, }) async handleNpmStylePath(@Context() ctx: EggContext, @HTTPParam() fullname: string, @HTTPParam() path: string, @HTTPQuery() meta: string) { // Validate fullname format if (!fullname.match(FULLNAME_REG_STRING)) { throw new Error('Invalid package name format'); } // Extract version from fullname, defaulting to 'latest' if not present // For scoped packages, split from the end to preserve the scope const parts = fullname.split('@'); let ver = parts.length > 2 ? parts.pop() : 'latest'; fullname = parts.join('@'); // Call the existing raw method with extracted information return await this.raw(ctx, fullname, ver, path, meta); }This refactored version includes input validation, explanatory comments, and a more descriptive method name.
|
unpkg 的路径我们支持这种 https://www.yuque.com/egg/cnpm/files ，这个变更不符合我们的要求。 |
fix #696
支持https://unpkg.com/ & https://www.jsdelivr.com/ 风格的路径
Summary by CodeRabbit
rawNpmVerfor handling GET requests with specific version specifications in the URL, allowing for more precise access to package files.rawNpmfor simplified access to the latest version of package files, enhancing user experience.