-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile failure for CH32V303CBT6 #348
Comments
I regret I don't have a CH32V303 here of any kind - I would expect it should use FUNCONF_PLL_MULTIPLIER 18 I am 99% sure we should just remove the CH32V20x precondition from line 12949. |
Can you remove and test? If so, can you make a PR? |
Blame falls on @AlexanderMandera -- this line looks like an actual error. But the plot is so messy... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not sure exactly how this should work, but I'm getting
My CH32V303CBT6 board definition has
-DCH32V30x -DCH32V303 -DCH32V30x_D8
defined (globally). My source for that is the datasheet.Then
ch32v003fun/ch32v003fun/ch32v003fun.h
Lines 168 to 182 in 49640fb
is going to activate
but
ch32v003fun/ch32v003fun/ch32v003fun.h
Lines 12918 to 12953 in 49640fb
will run into the
#error
because the#elif defined(CH32V20x) && FUNCONF_PLL_MULTIPLIER == 18
does not hold for it.Is that a bug in my activated macros for the CH32V303CBT6 or does ch32v003fun incorrectly account for it?
The text was updated successfully, but these errors were encountered: