Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK](ui): rework ContextMenu to become PopupMenu #529

Open
5 tasks
Tracked by #62
franzheidl opened this issue Oct 17, 2024 · 0 comments
Open
5 tasks
Tracked by #62

[TASK](ui): rework ContextMenu to become PopupMenu #529

franzheidl opened this issue Oct 17, 2024 · 0 comments
Assignees
Labels
ui-components All tasks related to juno-ui-components library

Comments

@franzheidl
Copy link
Contributor

franzheidl commented Oct 17, 2024

Task Description
The current ContextMenu component is flawed in several ways, and needs to be reworked as a more general PopupMenu component:

Sub-tasks

  • Re-write component in TS as a generic PopupMenu
  • Use the new PortalProvider to render the Menu into
  • Make component render as an overflow menu per default
  • Allow passing any Juno icon instead of default three vertical dots icon
  • Allow passing a custom component as a toggle as a prop into a slot

Related Issues
Will require migration of Menu and related MenuItem, MenuSection components to TypeScript #237

@franzheidl franzheidl added the ui-components All tasks related to juno-ui-components library label Oct 17, 2024
@franzheidl franzheidl self-assigned this Oct 17, 2024
@edda edda changed the title feat(ui): rework ContextMenu to become PopupMenu [TASK](ui): rework ContextMenu to become PopupMenu Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

No branches or pull requests

1 participant