Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFAC] - Standardise PluginPreset controller #584

Open
4 tasks
Tracked by #544
IvoGoman opened this issue Sep 17, 2024 · 0 comments
Open
4 tasks
Tracked by #544

[REFAC] - Standardise PluginPreset controller #584

IvoGoman opened this issue Sep 17, 2024 · 0 comments
Assignees

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Sep 17, 2024

As part of the standardisation of the reconciliation loop for Greenhouse controllers, this controller needs to be updated to follow the common recommendation for the Reconciliation

Acceptance Criteria

  • Implement the Interface
  • Use the standardised patch for updating the status instead of the deferred update (if applicable)
  • Convert the tests to use test.TestSetup (if applicable) including creation of missing resources
  • Remove dedicated finalizers used on the controllers because they are replaced with standard ones.
@IvoGoman IvoGoman changed the title [FEAT] - PluginPreset controller [REFAC] - PluginPreset controller Sep 17, 2024
@IvoGoman IvoGoman changed the title [REFAC] - PluginPreset controller [REFAC] - Standardise PluginPreset controller Sep 18, 2024
@IvoGoman IvoGoman assigned IvoGoman and Zaggy21 and unassigned IvoGoman Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint Backlog
Development

No branches or pull requests

2 participants