Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default port on local without ports #17

Open
mathieug opened this issue Apr 12, 2016 · 2 comments
Open

Default port on local without ports #17

mathieug opened this issue Apr 12, 2016 · 2 comments

Comments

@mathieug
Copy link
Contributor

We should be able to set a default port if we don't want to use ports package.
Why not in options of cfenv.getAppEnv(options)?

@pmuellr
Copy link
Member

pmuellr commented Jan 13, 2017

Seems like, in theory, you could do this by having an options object with the following shape, since the port is also specified in VCAP_APPLICATION:

{
  vcap: {
    application: {
      port: myPortNumber
    }
  }
}

Doesn't look like this would work today, as only env vars are checked, but ... the code could be changed to check that also.

Advantage of doing it that way is there are fewer options to set the port, which should make it easier to figure out what port to actually use. Disadvantage is that it's a bit of a mouthful to use - an explicit port value in options would be less wordy.

@pmuellr
Copy link
Member

pmuellr commented Jun 24, 2017

Is there still any interest in doing something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants