Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: wrangler dev --remote using interactive dev session in non-interactive terminal and ignores --show-interactive-dev-session=false #7025

Open
jdanyow opened this issue Oct 18, 2024 · 1 comment
Labels
bug Something that isn't working

Comments

@jdanyow
Copy link

jdanyow commented Oct 18, 2024

Which Cloudflare product(s) does this pertain to?

Wrangler

What version(s) of the tool(s) are you using?

3.81.0

What version of Node are you using?

No response

What operating system and version are you using?

Mac

Describe the Bug

After upgrading to 3.81.0, wrangler dev --remote started showing the interactive dev session controls, despite not being run in an interactive manner.

I use wireit to orchestrate npm scripts, and wireit does not currently support interactive sessions (google/wireit#56).

To reproduce without using wireit:

node -e 'require("child_process").spawn("wrangler dev --remote", { stdio: "pipe", shell: true }).stdout.on("data", data => { console.log(`stdout: ${data}`) })'

I tried to turn this off by using --show-interactive-dev-session=false but it had no effect.

wrangler dev --remote --show-interactive-dev-session=false

... outputs ...

╭──────────────────────────╮
│  [b] open a browser      │
│  [d] open devtools       │
│  [l] turn on local mode  │
│  [c] clear console       │
│  [x] to exit             │
╰──────────────────────────╯

Please provide a link to a minimal reproduction

No response

Please provide any relevant error logs

In my setup, the terminal output becomes mangled due to the interactive session output conflicting with the output from other commands which are running in parallel.

CleanShot 2024-10-18 at 12 26 06@2x

@jdanyow jdanyow added the bug Something that isn't working label Oct 18, 2024
@jdanyow
Copy link
Author

jdanyow commented Oct 18, 2024

The issue is fixed by adding --x-dev-env=false so it might be related to #6947 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
Projects
Status: Untriaged
Development

No branches or pull requests

1 participant