Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gritfile for provider version upgrade from 4.x to 5.x does not exist #4214

Closed
3 tasks done
fkonradmain opened this issue Oct 5, 2024 · 3 comments
Closed
3 tasks done
Labels
kind/support Categorizes issue or PR as related to user support.

Comments

@fkonradmain
Copy link

fkonradmain commented Oct 5, 2024

Confirmation

  • This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
  • I have searched the issue tracker and my issue isn't already found.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

5.0.0-alpha1

Affected resource(s)

  • cloudflare_record
  • cloudflare_dns_record

Terraform configuration files

resource "cloudflare_record" "mailcow_mx" {
    zone_id  = var.CLOUDFLARE_ZONE_ID
    name     = "@"
    content    = "${var.mail_subdomain}.${var.MAILCOW_DOMAIN}"
    type     = "MX"
    priority = 10
}

Link to debug output

https://pastebin.com/982y2Ahy

Panic output

No response

Expected output

$ grit apply terraform_cloudflare_v5

Processed 110 files and found 22 matches

$ grit list --language hcl
STANDARD LIBRARY PATTERNS

HCL patterns
✔ terraform_cloudflare_v5 (source: cloudflare/terraform-provider-cloudflare)
✔ cloudflare_record_deprecate_value_for_content (source: cloudflare/terraform-provider-cloudflare)
✔ cloudflare_zone_settings_override_deprecate_minify (source: cloudflare/terraform-provider-cloudflare)
✔ edit_module (source: getgrit/stdlib)
✔ kv_pair (source: getgrit/stdlib)

Actual output

$ grit apply terraform_cloudflare_v5

ERROR (code: 200) - pattern definition not found: terraform_cloudflare_v5. Try running grit init.

$ grit list --language hcl
STANDARD LIBRARY PATTERNS

HCL patterns
✔ cloudflare_record_deprecate_value_for_content (source: cloudflare/terraform-provider-cloudflare)
✔ cloudflare_zone_settings_override_deprecate_minify (source: cloudflare/terraform-provider-cloudflare)
✔ edit_module (source: getgrit/stdlib)
✔ kv_pair (source: getgrit/stdlib)

Steps to reproduce

In any directory run:

$ grit init
$ grit apply terraform_cloudflare_v5

Grit does not find this pattern even though it is documented here: https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/guides/version-5-upgrade#cloudflare_record. Even if this repo is imported (see yaml below), the pattern still won't exist.

Additional factoids

for comparison, how the output looks like when using cloudflare_record_deprecate_value

$ grit apply cloudflare_record_deprecate_value_for_content --dry-run

...
     resource "cloudflare_record" "mailcow_mx" {
       zone_id  = var.CLOUDFLARE_ZONE_ID
       name     = "@"
    -  value    = "${var.mail_subdomain}.${var.MAILCOW_DOMAIN}"
    +  content = "${var.mail_subdomain}.${var.MAILCOW_DOMAIN}"
       type     = "MX"
       priority = 10
     }
...

content of .grit/grit.yml:

version: 0.0.1
patterns:
  - name: github.com/getgrit/stdlib#*
  - name: github.com/cloudflare/terraform-provider-cloudflare#*

References

No response

@fkonradmain fkonradmain added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 5, 2024
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link
Contributor

github-actions bot commented Oct 5, 2024

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 5, 2024
@jacobbednarz
Copy link
Member

you need to reference the branch in the apply operation as it is not on master yet.

the local apply definitely works (it's what rewrites the tests and you can confirm it works with grit pattern test). if you're having issues with it locally, you're probably hitting a bug in grit. i know in the past i had to perform a global init instead to resolve.

@jacobbednarz jacobbednarz closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2024
@jacobbednarz jacobbednarz added kind/support Categorizes issue or PR as related to user support. and removed kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it. labels Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as related to user support.
Projects
None yet
Development

No branches or pull requests

2 participants