Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression Rulesets don't yet support zstandard algorithm #4144

Closed
3 tasks done
ebachle opened this issue Sep 30, 2024 · 2 comments · Fixed by #4300
Closed
3 tasks done

Compression Rulesets don't yet support zstandard algorithm #4144

ebachle opened this issue Sep 30, 2024 · 2 comments · Fixed by #4300
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Milestone

Comments

@ebachle
Copy link

ebachle commented Sep 30, 2024

Confirmation

  • This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
  • I have searched the issue tracker and my issue isn't already found.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform v1.8.5
on darwin_arm64
+ provider registry.terraform.io/cloudflare/cloudflare v4.43.0

Your version of Terraform is out of date! The latest version
is 1.9.5. You can update by downloading from https://www.terraform.io/downloads.html

1.8.5 vs 1.9.5 for terraform version shouldn't really matter.

Affected resource(s)

cloudflare_ruleset

Terraform configuration files

resource "cloudflare_ruleset" "compression_rules" {
  zone_id     = var.zone_id
  name        = "Compression Settings"
  description = "Compression Settings"
  kind        = "zone"
  phase       = "http_response_compression"
  rules {
    action = "compress_response"
    action_parameters {
      algorithms {
        name = "zstandard"
      }
      algorithms {
        name = "auto"
      }
    }
    expression  = "(http.response.content_type.media_type in {\"text/html\"})" # or any other expression
    description = "Zstandard"
    enabled     = true
  }
}

Link to debug output

Probably not necessary here

Panic output

No response

Expected output

It should accept zstandard here.

Actual output

terraform validate
│ Error: Invalid Attribute Value Match
│
│   with cloudflare_ruleset.compression_rules,
│   on rules-compression.tf line 11, in resource "cloudflare_ruleset" "compression_rules":
│   11:         name = "zstandard"
│
│ Attribute rules[0].action_parameters[0].algorithms[0].name value must be one of: ["gzip" "brotli" "auto" "default" "none"], got: "zstandard"

Steps to reproduce

  1. Using 4.43.0 of terraform
  2. Create a cloudflare_ruleset object for compression rules, and specify zstandard as the algorithm
  3. Receive error

Additional factoids

I'm happy to make the PR to fix it :)

References

No response

@ebachle ebachle added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 30, 2024
Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link
Contributor

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 30, 2024
@github-actions github-actions bot added this to the v4.45.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
1 participant