-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing custom attributes from empty list on Access apps doesn't work #3986
Comments
Community NoteVoting for Prioritization
Volunteering to Work on This Issue
|
I have fixed this bug locally and will submit a PR ASAP |
This functionality has been released in v4.42.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Confirmation
Terraform and Cloudflare provider version
Affected resource(s)
cloudflare_access_application
Terraform configuration files
Link to debug output
https://gist.github.com/BSFishy/ee9a8dd363f2d7c84ec0d7aab1c5415c
Panic output
No response
Expected output
When there are no custom attributes (or custom claims for OIDC apps), the attributes or claims should be removed.
Actual output
The attributes/claims are not removed.
Steps to reproduce
Additional factoids
The offending logic is found here:
terraform-provider-cloudflare/internal/sdkv2provider/schema_cloudflare_access_application.go
Lines 900 to 904 in 6f7d8d0
This logic was introduced in a PR (#3713) that updated cloudflare-go to a version where this issue may be resolved (providing nil doesn't touch the data, providing a slice sets the data to the slice), however this logic was originally misimplemented.
References
No response
The text was updated successfully, but these errors were encountered: