-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow compat no longer necessary? #34
Comments
@vemv Can you elaborate on this? This bit of piggieback interface has existed in Shadow forever. (since before |
Hmm, that was unexpected :) If that bit has always existed, then why is shadow-specific code needed at all? Maybe that bit doesn't work as intended? I'll be looking at this, mainly because in cider-nrepl we only use piggieback-based cljs stuff. And some features doesn't appear to work. So cider-nrepl would have to be fixed some way or another (fix the piggieback compat or introduce suitable-like compat to cider-nrepl code). |
We don't use anything else just because I didn't want to bother to learn shadow's API and Tomas (the author of Shadow) was kind enough to offer this basic compatibility. :-) In an ideal world we use shadow's own nREPL middleware, as it provides full access to shadow's functionality. I recall not everything was working properly with the piggieback adapter, but I haven't touched the ClojureScript code in cider-nrepl in ages and I've started to forget the details. |
See thheller/shadow-cljs#62 and thheller/shadow-cljs#561 Those are most useful discussions related to the nREPL support in shadow I could find now. |
Thanks much! I'll also check out https://github.com/thheller/shadow-cljs/blob/51b15dd52c74f1c504010f00cb84372bc2696a4d/src/main/shadow/cljs/devtools/server/nrepl.clj to see what it exactly does. |
One thing I've just realised is that cider-nrepl and refactor-nrepl use Perhaps using it here would simplify some code. |
Given
https://github.com/thheller/shadow-cljs/blob/51b15dd52c74f1c504010f00cb84372bc2696a4d/src/main/shadow/cljs/devtools/server/nrepl_impl.clj#L46-L59
, I believe it's no longer necessary to have shadow-cljs specific code.
The text was updated successfully, but these errors were encountered: