-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor times.py #359
Comments
Hi @cleder, Thanks |
Thanks @rishitc |
Hi @cleder, Thanks |
Can you document how to do it? For me, it is obvious, so I need an outsider's view on it to improve the documentation 😉 |
BTW, make a draft pull request, ask questions, I am happy to provide some guidance |
Hi @cleder,
Sure, I can work more on that as part of the #343
Thank you so much 😄 |
Hi @cleder, |
@cleder, also the new classes |
I am not sure what you are trying to say, can you make a draft PR? |
Sounds good, I'll put up my draft PR in the next hour 👍 |
Hi @cleder, Also, here's the current checklist status of my PR:
|
Refactor times to use the registry.
When
,Begin
andEnd
etree_element
and_get_kwargs
methods fromTimeStamp
andTimeSpan
GetKWArgs
Protocol to parse theKmlDateTime
from XMLSetElement
Protocol to create theetree
representationTimeStamp
to optionally take the abovewhen
TimeSpan
to optionally takebegin
andend
The text was updated successfully, but these errors were encountered: