Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions #27

Open
SelaO opened this issue Oct 9, 2018 · 3 comments
Open

Suggestions #27

SelaO opened this issue Oct 9, 2018 · 3 comments

Comments

@SelaO
Copy link

SelaO commented Oct 9, 2018 •
edited
Loading

The docs should mention having a separate person and company API.

And there should be an SDK for Name To Domain API.
@SelaO SelaO changed the title Question about combined API CombinedAPI is the same as PersonAPI Oct 9, 2018
@SelaO SelaO changed the title CombinedAPI is the same as PersonAPI Suggestions Oct 10, 2018
@harlow
Copy link
Member

harlow commented Oct 11, 2018 •
edited
Loading

Would love a PR if there are some areas that can be improved

https://github.com/clearbit/clearbit-java#supported-apis

harlow added a commit that referenced this issue Oct 11, 2018
@harlow
Deep link the different API types so readers
7982639 
#27
@SelaO
Copy link
Author

SelaO commented Oct 21, 2018 •
edited
Loading

Also, the three APIs in this sdk should have a common base class because I end up with three wrappers that do the same thing and I can't change it.

Is there anything I should know if I want to do a PR? And how fast will you upload it to the maven repo? Because I need to finish the feature and move on.

@harlow
Copy link
Member

harlow commented Oct 22, 2018

I can upload to Maven once the PR has been approved and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harlow @SelaO