Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: read: convert -n and -i to lookup list, do lookups #12

Open
cldellow opened this issue Jan 28, 2018 · 2 comments
Open

cli: read: convert -n and -i to lookup list, do lookups #12

cldellow opened this issue Jan 28, 2018 · 2 comments

Comments

@cldellow
Copy link
Owner

ATM we iterate and filter, which is very slow. Since each of -n and -i- match exactly 0 or 1 items, probably faster to look up their IDs and fetch the row by ID.

eg doing -n Heath_Ledger on an hour of data takes 13.8s
@cldellow
Copy link
Owner Author

We'd still benefit from this, but after fixing #13 this use case takes .52 seconds, so probably not worth pursuing right now

@cldellow cldellow reopened this Feb 4, 2018
@cldellow
Copy link
Owner Author

cldellow commented Feb 4, 2018

Reopening since this is really noticeable on slow media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cldellow