New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createBatchRequest need to handle the case when params is an empty array #615

Open

WhiteMinds opened this issue May 29, 2023 · 1 comment

Assignees

Labels

bug

WhiteMinds commented May 29, 2023

When params is an empty array, it results in an empty array payload.
As a result, the RPC service returns an empty string '' for the data. This leads to an error being thrown at this line: https://github.com/ckb-js/ckb-sdk-js/blob/5a462cab76e008c2d54e1c46eff02bf750ddc0c0/packages/ckb-sdk-rpc/src/index.ts#LL113C26-L113C26.

The text was updated successfully, but these errors were encountered:

Keith-CY self-assigned this

Keith-CY added the bug label

Keith-CY mentioned this issue

fix: return empty array if payload of batch request is an empty array #616

Merged

Member

Keith-CY commented Jun 6, 2023

Should be fixed by #616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment