Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --ignore-missing-imports flag from mypy pre-commit hook #103

Open
1 task
dav3r opened this issue Mar 16, 2022 · 0 comments
Open
1 task

Remove --ignore-missing-imports flag from mypy pre-commit hook #103

dav3r opened this issue Mar 16, 2022 · 0 comments
Assignees
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@dav3r
Copy link
Member

dav3r commented Mar 16, 2022

💡 Summary

Remove the --ignore-missing-imports flag from our mypy pre-commit hook.

Motivation and context

The mypy pre-commit hook that we use includes the --ignore-missing-imports flag by default, but we want to override that behavior. This will give us better mypy analysis and force us to document where type stubs are unavailable/missing.

For more context, see this discussion.

Implementation notes

Don't forget to put a helpful comment in the .pre-commit-config.yaml section explaining why we are adding this (or something like it):

args:
  # Add a useful comment here
  - --scripts-are-modules

Acceptance criteria

  • Our mypy pre-commit hook no longer includes the --ignore-missing-imports flag
@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

No branches or pull requests

2 participants