-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
branch i18n: setLanguage, namespace/domain and output->cache #132
Comments
Glad to hear it's working out for you! And I like the solution with cache path there, though I'd want to check for the config setting for cache path and go from there... but I like it. Will definitely implement. Thanks for the idea! |
@lonnieezell I've moved the call to set to the end of
I was using built-in So I think would be better to have a callback (event trigger) here instead of a wired Also, I think I'll have to patch the current i18n to not use CI's config language, I want to keep only english for CI's built-in messages, gettext for site translations, if I understand correctly once you set the config language, CI will look for this language for every built-in message, I don't want to install lang translations. I'm telling you about this because I think would be nice to have a generic implementation where the user can choose to use the official CI's config language or not. |
Not an issue, just FYI.
For a project where I need to manage multiple languages I'm using your classes (with gettext):
So far is working great, I only needed to add a little patch on
myth/Localization/I18n.php:setLanguage
in order to avoid collisions withoutput->cache
(output->cache
doesn't consider the lang segment and would have the same md5 filename)I'm using a trimmed version of CI and in my load sequence there's only
core/Router
betweencore/MY_URI
andcore/Output
, no places for the user to changecache_path
, thoughtsetLanguage
would be the best place for a callback, a config evaluation or an event trigger.Currently I'm just using a fast but raw patch:
The text was updated successfully, but these errors were encountered: