Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library version issue #32

Closed
bobcroft opened this issue Nov 1, 2020 · 6 comments
Closed

Library version issue #32

bobcroft opened this issue Nov 1, 2020 · 6 comments

Comments

@bobcroft
Copy link

bobcroft commented Nov 1, 2020

Hi, today I tried to compile the OctoPlugOut code, shared by Ruud Rademaker on the OctoPrint forum, using platformIO. I had an issue with the version of your library the platformIO downloaded 1.1.4 which appears to be the latest. However, it would not compile complaining of missing 'api.octoPrintCoreShutdown'. When I manually downloaded the library from Github as a zip file and then manually installed it in platformIO everything compiled correctly. I note that the most recent changes to the library include the missing item so I wondered if there is a versioning issue between what platformIO picks up and what is downloaded manually.

@chunkysteveo
Copy link
Owner

hiya,

Yes - that may well be the case - i've not set the library to work well with Platform IO as i've built it separate from that (old school!). This is probably the same issue as this issue about adding a manifest? I've not looked into it yet due to being busy, but if you have an update to make it work within Platform IO - pull requests are always welcome!!!! 😄

Steve

@chunkysteveo
Copy link
Owner

I've not updates the Arduino Library version for a while too.... I am the WORST programmer, haha!!!

@bobcroft
Copy link
Author

bobcroft commented Nov 2, 2020 via email

@chunkysteveo
Copy link
Owner

Have bumped the release version up to 1.1.5 as a test. Let me know how that goes now?

Steve

@bobcroft
Copy link
Author

bobcroft commented Nov 2, 2020 via email

@chunkysteveo
Copy link
Owner

Thats awesome news Bob. Thanks for letting me know it worked. Best of luck with Ruud's project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants