Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't remove all keys #42

Open
alexlafroscia opened this issue Dec 10, 2014 · 1 comment
Open

Doesn't remove all keys #42

alexlafroscia opened this issue Dec 10, 2014 · 1 comment

Comments

@alexlafroscia
Copy link

Something I noticed when cleaning up my keys here on Github is that gh-auth remove .... only removes the keys that the API reports the user had, not necessarily all of the keys in the authorized_keys file that are associated with that user.

For example, if you have 3 auth keys on your Github account, are added to a server, remove one of the keys from your account and then are removed from the server with gh-auth remove ..., only 2 keys will be removed from the authorized_keys file.

Does this pose a potential security issue? I would guess not, since you should only be adding people that you trust, but if someone wanted to be sneaky and try to have access to the server after you've removed them, I feel like this could be a problem.

@chrishunt
Copy link
Owner

@alexlafroscia Good point! Thank you. Since we're sticking the GitHub usernames in the keys file now, it might be a good idea to key off that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants