Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 changes package structure and breaks automated installs #283

Open
coolaj86 opened this issue Nov 25, 2023 · 2 comments
Open

v1.0.0 changes package structure and breaks automated installs #283

coolaj86 opened this issue Nov 25, 2023 · 2 comments

Comments

@coolaj86
Copy link

I like the new package structure, but it broke https://webinstall.dev/sd

I don't think there's really an action item here... BUT if you ever change the package structure in the future, please reach out.

Re: webinstall/webi-installers#779

@CosmicHorrorDev
Copy link
Collaborator

Apologies for the breakage. I had a little blurb at the top of the release notes talking about release artifact changes, but it wasn't really clear that it was part of a breaking change to the existing structure. I'll try to do better at explicitly calling that out in the future in release notes / change logs

I'll also try to remember to reach out, but there's a lot of downstream packagers, so I rely on them being mostly autonomous. That being said I do still want to keep packaging as easy as possible, so I will try to reach out in the future

@coolaj86
Copy link
Author

Thanks.

Webi grabs directly from the GitHub Releases API, so whatever you publish is exactly what is given to users with no middleman delay - no custom builds or delays in release.

I am working on some logic to make it more resilient to package changes... but there's 26,000 build assets over 100+ projects to download analyze to be able to come up with a "guaranteed to work" and "can still support oddball packages in the future" heuristic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants