esbuild-plugin-html only watches the HTML file

[louyshong]

Hi, I am struggling to setup watch mode using esbuild-plugin-html, it seems that only the HTML files specified in the entryPoints are being watched but not the JS files that are included in the script tags. Is this behaviour expected?

[cowwoc]

I am having the same problem. This is a showstopper for using this plugin.

@edoardocavazza can you please take a look?

[cowwoc]

Looking forward to trying out this fix. Do you plan to cut a release layer on today?

[edoardocavazza]

Hello @cowwoc, I have just released version 0.18.1. Let me know if it works as expected or feel free to re-open the issue.

[cowwoc]

Hi @edoardocavazza

I don't have permission to reopen this issue, but the bug is still there. I am passing in an HTML entry point that contains:

<script type="module" src="./bundle-shoelace.mts" defer></script>

However, when I modify bundle-shoelace.mts nothing happens. If I edit the HTML directly, then the changes get picked up. So esbuild watch is doing the right thing, but this plugin isn't working as expected...

[cowwoc]

I think I found the bug.

At

rna/packages/esbuild-rna/lib/Build.js

Line 724 in 6f5fefd

watchFiles.push();

you need to replace watchFiles.push(); with watchFiles.push(file);

[cowwoc]

I just tested the fix locally. It works!

[cowwoc]

Please merge #173 and cut a new release. Thank you.