Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(table): note that Offset must be set *after* Rows or it does nothing. #371

Open
bashbunni opened this issue Sep 20, 2024 · 1 comment · May be fixed by #408
Open

docs(table): note that Offset must be set *after* Rows or it does nothing. #371

bashbunni opened this issue Sep 20, 2024 · 1 comment · May be fixed by #408
Labels
documentation Improvements or additions to documentation

Comments

@bashbunni
Copy link
Member

If the table's rows are not set before Offset, it does nothing. This makes sense, but should be noted in the GoDoc

This works:

table := New().
	Rows(rows...).
	Offset(80).
	Height(45)

This doesn't

table := New().
	Offset(80).
	Rows(rows...).
	Height(45)
@bashbunni bashbunni added the documentation Improvements or additions to documentation label Sep 20, 2024
@bashbunni bashbunni changed the title docs(table): note that Offset() must be set *after* Rows or it does nothing. docs(table): note that Offset must be set *after* Rows or it does nothing. Sep 20, 2024
@bashbunni bashbunni linked a pull request Oct 21, 2024 that will close this issue
@bashbunni
Copy link
Member Author

Not sure if this is a thing for lists too 🤔 I've only seen this with tables, haven't tried to break lists...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant