Adding a node to get Closest divider of a number

[Roxy8311]

To upscale some image, I use a Split Spritesheet node the upscale each splitted part to merge them later. Problem with that, I need to change manually each time... So I kinda did something in my app to make it work on it's own, but it'll be cool if it's something that is already inside the app.

Here's my code (I know ... not perfect, but it work at least)

from __future__ import annotations

import math
from enum import Enum

from api import SpecialSuggestion
from nodes.properties.inputs import NumberInput
from nodes.properties.outputs import NumberOutput

from .. import custom_group


def closest_divisor(number: float, approximation: float) -> float:
    """
    Finds the closest divisor of a given number that is closest to the approximation.

    Args:
        number (float): The number for which to find divisors.
        approximation (float): The target value to approximate.

    Returns:
        float: The closest divisor to the approximation.
    """
    result = []
    for i in range(1, int(number) + 1):
        fl = float(i)
        calcul = number / fl
        if calcul.is_integer():
            result.append(calcul)

    if not result:
        raise ValueError("No divisors found.")

    closest = min(result, key=lambda x: abs(x - approximation))
    return closest * 1.0


@custom_group.register(
    schema_id="chainner:utility_closest_divisor",
    name="Closest Divisor",
    description="Find the closest divisor of a number excluding the number itself.",
    icon="MdCalculate",
    inputs=[
        NumberInput("Number", min=1, max=None, precision="unlimited", step=1).with_id(0),
        NumberInput("Divisor", min=None, max=None, precision="unlimited", step=1).with_id(1),
    ],
    outputs=[
        NumberOutput(
            "Closest Divisor",
            output_type="number",
        ).as_passthrough_of(0)
    ]
)
def closest_divisor_node(number: float, approximation: float) -> float:
    """
    Node function to find the closest divisor using the custom group schema.

    Args:
        number (float): The number for which to find the closest divisor.
        approximation (float): The target value to approximate.

    Returns:
        float: The closest divisor to the approximation.
    """
    return closest_divisor(number, approximation)

Since It's python, I kinda ... edited the app to make it work like I want to (so I created a Custom group inside Utility to make it easier for me).

I know it's not really a question, it's more of a proposition ... and my code is not to copy paste on the app, their is problem with it, just wanted to give an exemple of what could be possible (?).

[Roxy8311]

It looks something like that on the app

[joeyballentine]

Sorry for the late response. Thanks for the suggestion. I'm a bit busy at the moment but I'll see what I can do about implementing this