From 4d04a5ef7040f0b109121e102f30ea0e838595b3 Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Fri, 19 Jul 2024 11:18:25 +0200 Subject: [PATCH 1/8] [qa] remove useless code --- src/App.vue | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/App.vue b/src/App.vue index 894c572a3..16b784c1e 100644 --- a/src/App.vue +++ b/src/App.vue @@ -701,10 +701,6 @@ body { } } // End dark theme -#app .router-link-active { - color: #00d1b2; -} - .loading-info { background: white; } From 71dc348c6e5349d532b6649613cd96b9e914bff3 Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Fri, 19 Jul 2024 15:30:14 +0200 Subject: [PATCH 2/8] [qa] unmount the global preview modal if not in use --- src/App.vue | 3 ++- src/components/modals/base_modal.js | 16 +++++++++------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/App.vue b/src/App.vue index 16b784c1e..092e2b3fc 100644 --- a/src/App.vue +++ b/src/App.vue @@ -11,7 +11,8 @@ diff --git a/src/components/modals/base_modal.js b/src/components/modals/base_modal.js index 8622be3ab..dc571fa5f 100644 --- a/src/components/modals/base_modal.js +++ b/src/components/modals/base_modal.js @@ -22,14 +22,16 @@ export const modalMixin = { watch: { /* - * Make sure that the keydown event is removed each time, the modla is - * hidden. + * Make sure that the keydown event is removed each time the modal is hidden. */ - active() { - if (this.active) { - window.addEventListener('keydown', this.onKeyDown, false) - } else { - window.removeEventListener('keydown', this.onKeyDown) + active: { + immediate: true, + handler() { + if (this.active) { + window.addEventListener('keydown', this.onKeyDown, false) + } else { + window.removeEventListener('keydown', this.onKeyDown) + } } } } From 89631fe244f9ac61f1d09dd975b4063652c3dc23 Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Fri, 19 Jul 2024 15:31:15 +0200 Subject: [PATCH 3/8] [qa] unmount the shortcuts modal if not in use --- src/components/tops/Topbar.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/tops/Topbar.vue b/src/components/tops/Topbar.vue index edde0d66d..1f8ecf11d 100644 --- a/src/components/tops/Topbar.vue +++ b/src/components/tops/Topbar.vue @@ -215,8 +215,9 @@ From b1d115ccdaf79ed67bf5ffa0a29f159bfa723dbe Mon Sep 17 00:00:00 2001 From: Nicolas Pennec Date: Mon, 22 Jul 2024 09:51:30 +0200 Subject: [PATCH 4/8] [qa] improve and clean topbar widget --- src/components/tops/Topbar.vue | 201 +++++++++------------------------ 1 file changed, 55 insertions(+), 146 deletions(-) diff --git a/src/components/tops/Topbar.vue b/src/components/tops/Topbar.vue index 1f8ecf11d..ac54e55b6 100644 --- a/src/components/tops/Topbar.vue +++ b/src/components/tops/Topbar.vue @@ -1,18 +1,15 @@