We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceiling()
currentCeiling()
I am wondering if we actually need both methods:
function ceiling(uint loan) public view returns (uint) { if (borrowed[loan] > currentCeiling(loan)) { return 0; } return safeSub(currentCeiling(loan), borrowed[loan]); } function currentCeiling(uint loan) public view returns(uint) { bytes32 nftID_ = nftID(loan); return rmul(nftValues[nftID_], ceilingRatio[risk[nftID_]]); }
We only use ceiling here it seems. We could just use currentCeiling and remove the ceiling function.
ceiling
currentCeiling
Originally posted by @manuelpolzhofer in #567 (comment)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I am wondering if we actually need both methods:
We only use
ceiling
here it seems. We could just usecurrentCeiling
and remove theceiling
function.Originally posted by @manuelpolzhofer in #567 (comment)
The text was updated successfully, but these errors were encountered: