Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BuildValidator to enable/disable peer discovery on demand #145

Open
derrandz opened this issue Jan 18, 2023 · 0 comments
Open

Refactor BuildValidator to enable/disable peer discovery on demand #145

derrandz opened this issue Jan 18, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers test Request for creating a test-case

Comments

@derrandz
Copy link
Contributor

Origin

In a previous PR, we chose to make a minimal change to support enabling and disabling peer discovery for validators, just to avoid impacting the code base due to a function signature change.

We would like to drop this temporary minimal change in favor of a more well thought out one.
@derrandz derrandz added the good first issue Good for newcomers label Jan 18, 2023
@derrandz derrandz mentioned this issue Jan 18, 2023
Merged
11 tasks
@Bidon15 Bidon15 added enhancement New feature or request test Request for creating a test-case labels Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers test Request for creating a test-case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bidon15 @derrandz