Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When parsing shares, check that all shares belong to the same namespace #78

Open
4 tasks
cmwaters opened this issue Jun 19, 2024 · 1 comment
Open
4 tasks

When parsing shares, check that all shares belong to the same namespace #78

cmwaters opened this issue Jun 19, 2024 · 1 comment
Labels
bug Something isn't working go-square v2

Comments

@cmwaters
Copy link
Collaborator

cmwaters commented Jun 19, 2024 •
edited
Loading

Summary

Ref:

go-square/shares/parse_sparse_shares.go

Line 72 in 54314fc

// FIXME: it doesn't look like we check whether all the shares belong to the same namespace.

We currently don't check that subsequent shares still have the same namespace in a sequence

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@cmwaters cmwaters added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jun 19, 2024
@cristaloleg cristaloleg mentioned this issue Jun 19, 2024
Merged
@Wondertan
Copy link
Member

Share should have Validate func that validates it is correct and has the given namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working go-square v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wondertan @cmwaters