Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porposal: introduce Commitment method on share.Blob #114

Open
Wondertan opened this issue Oct 14, 2024 · 3 comments
Open

porposal: introduce Commitment method on share.Blob #114

Wondertan opened this issue Oct 14, 2024 · 3 comments

Comments

@Wondertan
Copy link
Member

Wondertan commented Oct 14, 2024

In the node, we have a Blob type that has the commitment cached on the Blob struct as a field. With all the type unification efforts, this seems to be the missing piece to fully migrate over go-square types.

Besides the node needs, it is generally handy to have a method that will lazily compute and cache the commitment on the blob, and users won't need to lookup inclusion pkg for the most common usecase.

@Wondertan
Copy link
Member Author

cc @vgonkivs, @cmwaters, @rootulp

@cmwaters
Copy link
Collaborator

Makes sense

@vgonkivs
Copy link
Member

Agree with @Wondertan. Can start working on this issue once migration to v2 is done.

@vgonkivs vgonkivs self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants